-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitAuto: [FEATURE] Implement Seller API #351
GitAuto: [FEATURE] Implement Seller API #351
Conversation
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Committed the Check Run |
Committed the Check Run |
Infisical secrets check: ✅ No secrets leaked! 💻 Scan logs12:30AM INF scanning for exposed secrets...
12:30AM INF 508 commits scanned.
12:30AM INF scan completed in 279ms
12:30AM INF no leaks found
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Quality Gate passedIssues Measures |
✅ Build VTEX-SDK-dotnet 2.3.1541 completed (commit a429765265 by @gitauto-ai[bot]) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
=====================================
Coverage 0.22% 0.22%
=====================================
Files 117 117
Lines 1774 1774
Branches 75 75
=====================================
Hits 4 4
+ Misses 1770 1768 -2
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
Resolves #53
What is the feature
Implement the Seller API, enabling the ability to consult, create, and update Sellers. A Seller represents the product owner within the system.
Why we need the feature
Introducing the Seller API is essential for managing product ownership effectively. It allows users to handle Sellers seamlessly, ensuring that product ownership details are accurately maintained and easily accessible. This enhances the overall management and scalability of the platform.
How to implement and why
API Endpoints:
Src/Controllers/SellerController.cs
to retrieve Seller information.Data Models:
Seller
model inSrc/Models/Seller.cs
that includes necessary properties such asId
,Name
,ContactInfo
, etc.Data Access Layer:
SellerRepository
inSrc/Repositories/SellerRepository.cs
to handle database interactions for Sellers, ensuring separation of concerns and maintainability.Validation:
SellerController
to ensure that all required fields are provided and adhere to expected formats, enhancing data integrity.Testing:
Tests/SellerAPI.Tests/SellerControllerTests.cs
to verify the functionality of each endpoint.Documentation:
docs
directory with detailed API documentation, providing examples and usage guidelines.Configuration:
This structured approach ensures that the Seller API is implemented efficiently, maintaining code quality and system reliability.
About backward compatibility
The implementation of the Seller API will maintain backward compatibility by introducing new endpoints without altering existing ones. Existing functionalities and APIs will remain unaffected, ensuring that current users and integrations continue to operate without disruption.
Test these changes locally